-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diamond to gridmanager #352
Conversation
update README.md in model/common
launch jenkins spack |
cscs-ci run default |
launch jenkins spack |
cscs-ci run |
cscs-ci run default |
…ger.py::test_get_start_end_index_for_global_grid
cscs-ci run |
cscs-ci run default |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a small typo, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally approved earlier as I didn't see that there were actually still a few unresolved comments...
- add default argument for on_gpu - run test_smagorinsky.py on roundtrip backend
launch jenkins spack |
cscs-ci run default |
cscs-ci run |
cscs-ci run default |
launch jenkins spack |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run default |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
constructs the E2C2E and E2C2EO connectivities in grid_manager.py |
E2C2E
andE2C2EO
connectivities ingrid_manager.py
E2C2V
connectivity such that it matches the one in ICON.test_grid_manager.py
now validates against the grid file used inmch_ch_r04b09_dsl
and theicon_grid_0013_R02B04_R.nc
used inexclaim_ape_R02B04