Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diamond to gridmanager #352

Merged
merged 28 commits into from
Feb 7, 2024
Merged

Add diamond to gridmanager #352

merged 28 commits into from
Feb 7, 2024

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Jan 18, 2024

  • constructs the E2C2E and E2C2EO connectivities in grid_manager.py
  • fixes the index ordering of E2C2V connectivity such that it matches the one in ICON.
  • test_grid_manager.py now validates against the grid file used in mch_ch_r04b09_dsl and the icon_grid_0013_R02B04_R.nc used in exclaim_ape_R02B04

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge halungge marked this pull request as ready for review January 18, 2024 15:02
@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

cscs-ci run default

model/common/src/icon4py/model/common/grid/grid_manager.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/grid_manager.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/grid_manager.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/grid/grid_manager.py Outdated Show resolved Hide resolved
model/common/tests/grid_tests/test_grid_manager.py Outdated Show resolved Hide resolved
model/common/tests/grid_tests/utils.py Outdated Show resolved Hide resolved
model/common/tests/grid_tests/utils.py Outdated Show resolved Hide resolved
model/common/tests/grid_tests/utils.py Outdated Show resolved Hide resolved
model/common/tests/grid_tests/utils.py Outdated Show resolved Hide resolved
@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small typo, looks good!

model/common/tests/grid_tests/test_grid_manager.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved earlier as I didn't see that there were actually still a few unresolved comments...

@halungge
Copy link
Contributor Author

halungge commented Feb 5, 2024

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Feb 5, 2024

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

launch jenkins spack

Copy link

github-actions bot commented Feb 6, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

launch jenkins spack

Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@halungge
Copy link
Contributor Author

halungge commented Feb 7, 2024

constructs the E2C2E and E2C2EO connectivities in grid_manager.py
fixes the index ordering of E2C2V connectivity such that it matches the one in ICON.

@halungge halungge merged commit 9081e6d into main Feb 7, 2024
5 checks passed
@halungge halungge deleted the add_diamond_to_gridmanager branch December 12, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants